Skip to content

Conversation

@sbucaille
Copy link
Contributor

What does this PR do?

Fixes #38663 (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • [] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1 @amyeroberts @qubvel

@sbucaille sbucaille changed the title fix: grouped the two MODEL_FOR_MASK_GENERATION_MAPPING_NAMES variables Fixed modeling_auto.py MODEL_FOR_MASK_GENERATION_MAPPING_NAMES variable Jun 7, 2025
@sbucaille sbucaille mentioned this pull request Jun 7, 2025
Copy link
Contributor

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @sbucaille!

@Rocketknight1
Copy link
Member

I spotted this one already at #38614, but I can't approve my own PRs so I'll merge this one instead 😅

@Rocketknight1 Rocketknight1 enabled auto-merge (squash) June 9, 2025 13:32
@Rocketknight1 Rocketknight1 merged commit 237ff80 into huggingface:main Jun 9, 2025
20 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

bvantuan pushed a commit to bvantuan/transformers that referenced this pull request Jun 12, 2025
…le (huggingface#38664)

fix: grouped the two MODEL_FOR_MASK_GENERATION_MAPPING_NAMES variables
@sbucaille sbucaille deleted the fix_modeling_auto_sam branch July 6, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MODEL_FOR_MASK_GENERATION_MAPPING_NAMES variable is present twice in modeling_auto.py

4 participants