Skip to content

Conversation

@gante
Copy link
Member

@gante gante commented Jun 20, 2025

What does this PR do?

Follow-up to #38758

This PR removes TF tests with the require_tf decorator. All uses of require_tf were removed, and a deprecation message was added to this test-related function.

(If this PR is approved, I'll open similar PRs for other related decorators, such as require_flax)


@require_vision
@require_torchvision
class SamProcessorEquivalenceTest(unittest.TestCase):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this class has no tests 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Rocketknight1 for git blame :-)

@gante gante requested review from Rocketknight1 and ydshieh June 20, 2025 15:33

# tf RNG
import tensorflow as tf
import tensorflow as tf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok here, but if you want to delete also fine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted ✅

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy, we still have so many tf stuff! Thank you sir

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even think to search for require_tf! Good thinking

@ydshieh
Copy link
Collaborator

ydshieh commented Jun 25, 2025

Let's mergeeeeeeee (no?)

@gante gante enabled auto-merge (squash) June 25, 2025 17:22
@gante
Copy link
Member Author

gante commented Jun 25, 2025

automerge enabled 👍

@gante gante merged commit 1d45d90 into huggingface:main Jun 25, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants