-
Notifications
You must be signed in to change notification settings - Fork 31k
[tests] remove TF tests (uses of require_tf)
#38944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| @require_vision | ||
| @require_torchvision | ||
| class SamProcessorEquivalenceTest(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this class has no tests 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Rocketknight1 for git blame :-)
docs/source/en/testing.md
Outdated
|
|
||
| # tf RNG | ||
| import tensorflow as tf | ||
| import tensorflow as tf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok here, but if you want to delete also fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted ✅
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holy, we still have so many tf stuff! Thank you sir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even think to search for require_tf! Good thinking
|
Let's mergeeeeeeee (no?) |
|
automerge enabled 👍 |
What does this PR do?
Follow-up to #38758
This PR removes TF tests with the
require_tfdecorator. All uses ofrequire_tfwere removed, and a deprecation message was added to this test-related function.(If this PR is approved, I'll open similar PRs for other related decorators, such as
require_flax)