Skip to content

Conversation

@skwh54
Copy link
Contributor

@skwh54 skwh54 commented Jul 20, 2025

What does this PR do?

Translated the how_to_hack_models.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
@4N3MONE, @yijun-lee, @jungnerd , @harheem

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@Rocketknight1
Copy link
Member

cc @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! We can merge after a Korean reader has reviewed your translation :)

@4N3MONE
Copy link
Contributor

4N3MONE commented Jul 22, 2025

LGTM! 번역 고생하셨습니다 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
Copy link
Member

Feel free to mark as ready for review whenever you're ready!

Copy link
Contributor

@yijun-lee yijun-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고 많으셨습니다 :)

Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤗 merge를 위해 PR의 상태를 draft에서 open으로 변경해주세요!

Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skwh54 skwh54 marked this pull request as ready for review July 25, 2025 07:08
@stevhliu stevhliu merged commit 1d06153 into huggingface:main Jul 29, 2025
15 checks passed
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…#39536)

* docs: ko: how_to_hack_models.md

* feat: nmt draft

* fix: manual edits
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…#39536)

* docs: ko: how_to_hack_models.md

* feat: nmt draft

* fix: manual edits
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…#39536)

* docs: ko: how_to_hack_models.md

* feat: nmt draft

* fix: manual edits
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…#39536)

* docs: ko: how_to_hack_models.md

* feat: nmt draft

* fix: manual edits
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…#39536)

* docs: ko: how_to_hack_models.md

* feat: nmt draft

* fix: manual edits
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…#39536)

* docs: ko: how_to_hack_models.md

* feat: nmt draft

* fix: manual edits
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…#39536)

* docs: ko: how_to_hack_models.md

* feat: nmt draft

* fix: manual edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants