[chat template] update when "push_to_hub" #39815
Merged
+74
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
@Rocketknight1 kind ping |
Member
Author
|
It got stale a bit, so ping again @Rocketknight1 . Whenever you got some time 😄 |
Rocketknight1
approved these changes
Oct 9, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
It looks good, and the tests are really helpful! One comment about the Hub change, though, it conflicts with one of my PRs. My fault, though - your PR came first.
src/transformers/utils/hub.py
Outdated
| try: | ||
| return [ | ||
| entry.path.removeprefix(f"{CHAT_TEMPLATE_DIR}/") | ||
| entry.path.removeprefix(f"{CHAT_TEMPLATE_DIR}/").removesuffix(".jinja") |
Member
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
* update templates push to hub * rvert jinja suffix and move it to processor file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed internally, we don't have tests for chat templates loading-pushing to hub and a few bugs were encountered recently