Revert "remove dtensors, not explicit (#39840)" #39912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
approved these changes
Aug 5, 2025
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
SGTM ! Let's make it work later so that we can easily train with deepspeed + tp or fsdp + tp
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ce#39912) * Revert "remove dtensors, not explicit (huggingface#39840)" This did not work with generation (lm_head needs extra care!) This reverts commit 6dfd561. * update * style?
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ce#39912) * Revert "remove dtensors, not explicit (huggingface#39840)" This did not work with generation (lm_head needs extra care!) This reverts commit 6dfd561. * update * style?
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ce#39912) * Revert "remove dtensors, not explicit (huggingface#39840)" This did not work with generation (lm_head needs extra care!) This reverts commit 6dfd561. * update * style?
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ce#39912) * Revert "remove dtensors, not explicit (huggingface#39840)" This did not work with generation (lm_head needs extra care!) This reverts commit 6dfd561. * update * style?
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ce#39912) * Revert "remove dtensors, not explicit (huggingface#39840)" This did not work with generation (lm_head needs extra care!) This reverts commit 6dfd561. * update * style?
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ce#39912) * Revert "remove dtensors, not explicit (huggingface#39840)" This did not work with generation (lm_head needs extra care!) This reverts commit 6dfd561. * update * style?
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ce#39912) * Revert "remove dtensors, not explicit (huggingface#39840)" This did not work with generation (lm_head needs extra care!) This reverts commit 6dfd561. * update * style?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This did not work with generation (lm_head needs extra care!) This reverts commit 6dfd561.
cc @SunMarc cc @matej-svejda