Add num_hidden_layers to t5gemma's top level config #41239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug that for generating with cache using T5Gemma. Due to the nested structure of its config class, the field
num_hidden_layers, which is used to initialize a dynamic cache, only exists underconfig.decoder.This PR added a one line change to initialize
config.num_hidden_layersusingconfig.decoder.num_hidden_layers.Fixes #41073
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@gante @Rocketknight1
Following up on this issue since I encountered the same error. Happy to provide more information or discuss alternative solutions to help get this merged :)