[v5] Bump min version of bitsandbytes to 0.46.1 #41283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
MekkCyber
approved these changes
Oct 2, 2025
Contributor
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Very very nice ! Thanks for the cleaning
Comment on lines
89
to
93
| if not is_torch_available(): | ||
| raise ImportError( | ||
| "The bitsandbytes library requires PyTorch but it was not found in your environment. " | ||
| "You can install it with `pip install torch`." | ||
| ) |
Contributor
There was a problem hiding this comment.
why removing the torch check ?
Member
Author
There was a problem hiding this comment.
this shouldn't be needed tbh as torch is the only backend available for v5. We didn't put it for other quantizers btw
matthewdouglas
approved these changes
Oct 2, 2025
Member
matthewdouglas
left a comment
matthewdouglas
left a comment
There was a problem hiding this comment.
Thanks for cleaning all of this up!
SunMarc
changed the title
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bnb |
Member
Author
|
run-slow: bnb |
Contributor
|
This comment contains run-slow, running the specified jobs: models: [] |
Member
Author
|
All tests are passing ! |
snorkelopstesting1-a11y
pushed a commit
to snorkel-marlin-repos/huggingface_transformers_pr_41283_77f395cf-9a0d-40a1-8f4d-8850942b7f0d
that referenced
this pull request
Oct 11, 2025
Original PR #41283 by SunMarc Original: huggingface/transformers#41283
snorkelopstesting1-a11y
added a commit
to snorkel-marlin-repos/huggingface_transformers_pr_41283_77f395cf-9a0d-40a1-8f4d-8850942b7f0d
that referenced
this pull request
Oct 11, 2025
Merged from original PR #41283 Original: huggingface/transformers#41283
snorkelopstesting1-a11y
pushed a commit
to snorkel-marlin-repos/huggingface_transformers_pr_41283_2b1fe0e3-c8bd-4b56-af6b-5fc12ad4e35d
that referenced
this pull request
Oct 11, 2025
Original PR #41283 by SunMarc Original: huggingface/transformers#41283
snorkelopstesting1-a11y
added a commit
to snorkel-marlin-repos/huggingface_transformers_pr_41283_2b1fe0e3-c8bd-4b56-af6b-5fc12ad4e35d
that referenced
this pull request
Oct 11, 2025
Merged from original PR #41283 Original: huggingface/transformers#41283
AhnJoonSung
pushed a commit
to AhnJoonSung/transformers
that referenced
this pull request
Oct 12, 2025
* bump bitsandbytes to 0.46.1 * huge cleanup * style * fix * req * fix * importerror * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR cleans bitsandbytes integration as we bump the min version. With the multi-backend integrated in bitsanbytes for a few versions, I think we can safely bump to 0.46.1 as vllm did. I also removed a bunch as deprecated code