Skip to content

Conversation

@junjunjd
Copy link

  • Add clear error message when mistral-common is missing for AutoTokenizer loading Voxtral
  • Add unit test

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@junjunjd junjunjd force-pushed the fix/error-msg-voxtral-mistral-common branch 2 times, most recently from e4fea07 to b3579fe Compare October 29, 2025 06:05
@junjunjd junjunjd force-pushed the fix/error-msg-voxtral-mistral-common branch from b3579fe to 986940a Compare October 29, 2025 06:19
@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto, voxtral

@Rocketknight1
Copy link
Member

Rocketknight1 commented Oct 29, 2025

cc @vasqu we have quite a few PRs for this now and should probably merge one! This one seems clean, but #41592 has been open for longer

@vasqu
Copy link
Contributor

vasqu commented Oct 29, 2025

Sorry about that one, imo we should prioritize #41592, left a comment there

This PR will only work for voxtral, we should make this as general as possible as in the other PR

@Khansa435
Copy link

Khansa435 commented Oct 29, 2025

Hi @Rocketknight1 @vasqu . I've worked on @vasqu suggestion and did changes .My PR #41592 passes all tests. One test (build_pr_documentation) is pending and rest are all clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants