Don't discard entity_group when token is the last in the sequence. #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Funtowicz <funtowiczmo@gmail.com>
mfuntowicz
force-pushed
the
ner-group-entities-last-token
branch
from
47c645e to
3f5a220
Compare
|
LGTM! Thanks @mfuntowicz ! Before: In [6]: nlp("My name is Wolfgang and I live in Berlin")
Out[6]: [{'entity_group': 'I-PER', 'score': 0.9991481900215149, 'word': 'Wolfgang'}]With this PR: In [5]: nlp("My name is Wolfgang and I live in Berlin")
Out[5]:
[{'entity_group': 'I-PER', 'score': 0.9991481900215149, 'word': 'Wolfgang'},
{'entity_group': 'I-LOC', 'score': 0.9983668327331543, 'word': 'Berlin'}] |
stefan-it
approved these changes
Jul 1, 2020
mfuntowicz
changed the title
|
@LysandreJik CI error seems unrelated, is it ok for you if I merge? |
|
Did you check this, @enzoampil? Just making sure to ping you as you contributed #3957 🤗 |
|
@julien-c Did a few checks as well and looks great! Was planning to include this in this PR #4987 (2nd point), but this seems to solve it cleanly already, so will consider this fix for that PR 😄 UPDATE: Ended up modifying this fix in the PR above, due to cases where the last token was repeating (for the test cases set in the above PR). |
enzoampil
added a commit
to enzoampil/transformers
that referenced
this pull request
Jul 4, 2020
enzoampil
added a commit
to enzoampil/transformers
that referenced
this pull request
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Morgan Funtowicz funtowiczmo@gmail.com