Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added indexes in grouped entity NER #5677

Conversation

prithvikannan
Copy link

Based on issue #5676

Any application that requires users to locate grouped named entities would require some sort of index. This feature is present in the standard NER pipeline and should also exist in the grouped entity NER pipeline as well. This is a very short addition to the model and is a relevant use case to many developers.

prithvikannan and others added 3 commits July 10, 2020 21:30
* Add Microsoft's CodeBERT

* link style

* single modal

* unused import
* Add model type check for pipelines

* Add model type check for pipelines

* rename func

* Fix the init parameters

* Fix format

* rollback unnecessary refactor
@prithvikannan prithvikannan changed the title Added indexes in grouped entity NER [WIP] Added indexes in grouped entity NER Jul 12, 2020
onepointconsulting and others added 26 commits July 13, 2020 02:53
Added general description, information about the tags and also some example usage code.
* Fix Trainer in DataParallel setting

* Fix typo

Co-authored-by: Sam Shleifer <sshleifer@gmail.com>
* fix longformer global attention output

* fix multi gpu problem

* replace -10000 with 0

* better comment

* make attention output equal local and global

* Update src/transformers/modeling_longformer.py
* implement FlaubertForTokenClassification as a subclass of XLMForTokenClassification

* fix mapping order

* add the doc

* add common tests
…ation head for text classification (huggingface#5198)

* Reformer model head classification implementation for text classification

* Reformat the reformer model classification code

* PR review comments, and test case implementation for reformer for classification head changes

* CI/CD reformer for classification head test import error fix

* CI/CD test case implementation  added ReformerForSequenceClassification to all_model_classes

* Code formatting- fixed

* Normal test cases added for reformer classification head

* Fix test cases implementation for the reformer classification head

* removed token_type_id parameter from the reformer classification head

* fixed the test case for reformer classification head

* merge conflict with master fixed

* merge conflict, changed reformer classification to accept the choice_label parameter added in latest code

* refactored the the reformer classification head test code

* reformer classification head, common transform test cases fixed

* final set of the review comment, rearranging the reformer classes and docstring add to classification forward method

* fixed the compilation error and text case fix for reformer classification head

* Apply suggestions from code review

Remove unnecessary dup

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
* docs(wandb): explain how to use W&B integration

fix huggingface#5262

* Also mention TensorBoard

Co-authored-by: Julien Chaumond <chaumond@gmail.com>
Model card for hewiki-articles-distilGPT2py-il
A tiny GPT2 model for generating Hebrew text
* Customize inference widget input

* Update model_cards/mrm8488/RuPERTa-base/README.md

Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>
…uggingface#5665)

* fix auto model causal lm

* leverage given functionality

* apply unused kwargs to all auto models
Signed-off-by: Morgan Funtowicz <morgan@huggingface.co>
Pavel Soriano and others added 25 commits July 28, 2020 20:33
* add a link to README.md

* Update README.md
Co-authored-by: Julien Chaumond <chaumond@gmail.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Co-authored-by: Teven <teven.lescao@gmail.com>
* Make all data collators accept dict

* Style
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #5677 into master will increase coverage by 0.39%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5677      +/-   ##
==========================================
+ Coverage   78.11%   78.51%   +0.39%     
==========================================
  Files         146      146              
  Lines       25983    26326     +343     
==========================================
+ Hits        20297    20669     +372     
+ Misses       5686     5657      -29     
Impacted Files Coverage Δ
src/transformers/commands/train.py 0.00% <ø> (ø)
src/transformers/benchmark/benchmark_tf.py 65.03% <50.00%> (+3.49%) ⬆️
src/transformers/__init__.py 99.24% <100.00%> (ø)
src/transformers/benchmark/benchmark.py 81.88% <100.00%> (+7.87%) ⬆️
src/transformers/modeling_tf_distilbert.py 64.90% <0.00%> (-33.90%) ⬇️
src/transformers/tokenization_openai.py 71.21% <0.00%> (-12.88%) ⬇️
src/transformers/testing_utils.py 72.72% <0.00%> (-3.75%) ⬇️
src/transformers/data/data_collator.py 97.41% <0.00%> (-1.69%) ⬇️
src/transformers/modeling_longformer.py 89.21% <0.00%> (-0.51%) ⬇️
src/transformers/data/processors/squad.py 28.13% <0.00%> (-0.22%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fad617...516926a. Read the comment docs.

@prithvikannan
Copy link
Author

Made changes suggested by @LysandreJik, then rebased.

@stale
Copy link

stale bot commented Sep 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 27, 2020
@stale stale bot closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.