-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[marian] converter supports models from new Tatoeba project #6342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6342 +/- ##
==========================================
+ Coverage 78.42% 79.41% +0.99%
==========================================
Files 156 156
Lines 28129 28129
==========================================
+ Hits 22061 22340 +279
+ Misses 6068 5789 -279
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, incredibly simple diff for 300 new models, great stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, thanks for adding these!
ara-eng
. This is the new format.ara-eng
Done:
Todo:
ara-eng
->ar-en
.tags
, more info on all possible language codes.cc @julien-c
Dict where keys are old names, and values are new names, filtered to situations where new name has higher BLEU than old name: