[lightning_base] fix s2s logging, only make train_loader once #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshleifer
commented
Aug 11, 2020
| @@ -31,3 +34,24 @@ def test_run_ner(self): | |||
| with patch.object(sys, "argv", ["run.py"] + testargs): | |||
| result = run_ner.main() | |||
| self.assertLess(result["eval_loss"], 1.5) | |||
|
|
|||
|
|
|||
| def test_run_ner_pl(self): | |||
There was a problem hiding this comment.
this doesn't test lightning and should be in a separate PR.
sshleifer
commented
Aug 11, 2020
sshleifer
changed the title
sshleifer
commented
Aug 11, 2020
| @@ -161,13 +161,6 @@ def add_model_specific_args(parser, root_dir): | |||
| type=int, | |||
| help="The number of GPUs allocated for this, it is by default 0 meaning none", | |||
| ) | |||
| parser.add_argument( | |||
There was a problem hiding this comment.
centralize data_dir argument to add_generic_args cause rule of 3
Codecov Report
@@ Coverage Diff @@
## master #6404 +/- ##
==========================================
- Coverage 80.38% 80.26% -0.12%
==========================================
Files 156 156
Lines 28058 28058
==========================================
- Hits 22554 22521 -33
- Misses 5504 5537 +33
Continue to review full report at Codecov.
|
sshleifer
changed the title
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…huggingface#6404)" This reverts commit 59da5d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup is called many times (incl twice by trainer.test), creating a dataloader each time. Will only creating a train_loader on the first call cause bad side effects that I don't understand @nateraw @williamFalcon ?
I read docs [https://pytorch-lightning.readthedocs.io/en/latest/introduction_guide.html], so I think I'm fine, but not sure.
cc @stas00
Also:
data_dirargument toadd_generic_argscause rule of 3Checks: