Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs model summaries] Add pegasus to docs #6640

Merged

Conversation

patrickvonplaten
Copy link
Contributor

Stiched together a short model summary for Pegasus. Would be great if @sshleifer and @sgugger can take a look :-)

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #6640 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6640      +/-   ##
==========================================
- Coverage   79.14%   79.12%   -0.03%     
==========================================
  Files         156      156              
  Lines       28248    28248              
==========================================
- Hits        22358    22351       -7     
- Misses       5890     5897       +7     
Impacted Files Coverage Δ
src/transformers/generation_tf_utils.py 80.70% <0.00%> (-2.01%) ⬇️
src/transformers/file_utils.py 82.41% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e42a7...773081d. Read the comment docs.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for updating the model summary!

Copy link
Contributor

@sshleifer sshleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. But the info is now in ~3 places.
Model card, pegasus.rst, and here.
That seems like a lot of places. Can we kill 1?

@patrickvonplaten
Copy link
Contributor Author

patrickvonplaten commented Aug 21, 2020

I guess we could in general link the model summaries to the model doc as well or vice-versa for each model?

@patrickvonplaten patrickvonplaten merged commit a4db4e3 into huggingface:master Aug 21, 2020
@julien-c
Copy link
Member

We also should probably automatically link each model card to its doc

In the meantime, I think duplication is fine:)

Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
* add pegasus to docs

* Update docs/source/model_summary.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants