-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs model summaries] Add pegasus to docs #6640
[Docs model summaries] Add pegasus to docs #6640
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6640 +/- ##
==========================================
- Coverage 79.14% 79.12% -0.03%
==========================================
Files 156 156
Lines 28248 28248
==========================================
- Hits 22358 22351 -7
- Misses 5890 5897 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks for updating the model summary!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. But the info is now in ~3 places.
Model card, pegasus.rst, and here.
That seems like a lot of places. Can we kill 1?
I guess we could in general link the model summaries to the model doc as well or vice-versa for each model? |
We also should probably automatically link each model card to its doc In the meantime, I think duplication is fine:) |
* add pegasus to docs * Update docs/source/model_summary.rst
Stiched together a short model summary for Pegasus. Would be great if @sshleifer and @sgugger can take a look :-)