Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PULL_REQUEST_TEMPLATE.md #6660

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Aug 22, 2020

Proposing to copy this neat feature from pytorch. This is a small template that let's a PR submitter tell which issue that PR closes.

Here is an example of it in action, the end of the top post: #6659

Proposing to copy this neat feature from pytorch. This is a small template that let's a PR submitter tell which issue that PR closes.
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #6660 into master will increase coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6660      +/-   ##
==========================================
+ Coverage   79.01%   79.65%   +0.64%     
==========================================
  Files         156      156              
  Lines       28248    28248              
==========================================
+ Hits        22320    22502     +182     
+ Misses       5928     5746     -182     
Impacted Files Coverage Δ
src/transformers/modeling_tf_flaubert.py 24.53% <0.00%> (-63.81%) ⬇️
src/transformers/modeling_tf_utils.py 86.64% <0.00%> (+1.30%) ⬆️
src/transformers/modeling_tf_electra.py 98.95% <0.00%> (+73.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f94151...73edfdc. Read the comment docs.

Copy link
Contributor

@JetRunner JetRunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment? Please change the suggested line if you have a better comment.

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>
@JetRunner JetRunner merged commit a8d6716 into huggingface:master Aug 24, 2020
@stas00 stas00 deleted the patch-2 branch August 24, 2020 16:35
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
* Create PULL_REQUEST_TEMPLATE.md

Proposing to copy this neat feature from pytorch. This is a small template that let's a PR submitter tell which issue that PR closes.

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>

Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
* Create PULL_REQUEST_TEMPLATE.md

Proposing to copy this neat feature from pytorch. This is a small template that let's a PR submitter tell which issue that PR closes.

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>

Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants