-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PULL_REQUEST_TEMPLATE.md #6660
Conversation
Proposing to copy this neat feature from pytorch. This is a small template that let's a PR submitter tell which issue that PR closes.
Codecov Report
@@ Coverage Diff @@
## master #6660 +/- ##
==========================================
+ Coverage 79.01% 79.65% +0.64%
==========================================
Files 156 156
Lines 28248 28248
==========================================
+ Hits 22320 22502 +182
+ Misses 5928 5746 -182
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment? Please change the suggested line if you have a better comment.
Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>
* Create PULL_REQUEST_TEMPLATE.md Proposing to copy this neat feature from pytorch. This is a small template that let's a PR submitter tell which issue that PR closes. * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Kevin Canwen Xu <canwenxu@126.com> Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>
* Create PULL_REQUEST_TEMPLATE.md Proposing to copy this neat feature from pytorch. This is a small template that let's a PR submitter tell which issue that PR closes. * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Kevin Canwen Xu <canwenxu@126.com> Co-authored-by: Kevin Canwen Xu <canwenxu@126.com>
This reverts commit ae98a63.
Proposing to copy this neat feature from pytorch. This is a small template that let's a PR submitter tell which issue that PR closes.
Here is an example of it in action, the end of the top post: #6659