[squad] make examples and dataset accessible from SquadDataset object #6710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazovich
force-pushed
the
squad-dataset-updates
branch
from
07ce328 to
1dbe4bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #6710 +/- ##
==========================================
- Coverage 80.06% 78.78% -1.28%
==========================================
Files 156 156
Lines 28386 28391 +5
==========================================
- Hits 22726 22367 -359
- Misses 5660 6024 +364
Continue to review full report at Codecov.
|
LysandreJik
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
This looks good to me, but will break existing saved features. I don't think that's too much of an issue though, what do you think @sgugger?
sgugger
reviewed
Aug 25, 2020
|
@sgugger @LysandreJik thanks so much for the comments/suggestions! I have updated the code to include support for the legacy cache format. I had a question on one comment, but if there are any other changes needed please let me know. |
sgugger
approved these changes
Aug 25, 2020
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
…huggingface#6710) * [squad] make examples and dataset accessible from SquadDataset object * [squad] add support for legacy cache files
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…huggingface#6710) * [squad] make examples and dataset accessible from SquadDataset object * [squad] add support for legacy cache files
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…t object (huggingface#6710)" This reverts commit 83848b6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to do evaluation on the SQuAD dataset using squad_evaluate, the user needs access to both the examples loaded in the dataset and the TensorDataset that contains values like unique_id and the like that are used in constructing the list of SquadResult objects. This PR surfaces the examples and dataset to the user so that they can access it directly.
For example of why access to those is needed, see how evaluation is currently done in examples/run_squad.py. The SquadDataset object attempts to wrap up some of this functionality, but without access to examples and dataset the evaluation is not possible.