-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ONNX test_quantize unittest #6716
Conversation
Signed-off-by: Morgan Funtowicz <funtowiczmo@gmail.com>
Signed-off-by: Morgan Funtowicz <funtowiczmo@gmail.com>
Signed-off-by: Morgan Funtowicz <funtowiczmo@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6716 +/- ##
==========================================
+ Coverage 78.98% 80.01% +1.03%
==========================================
Files 156 156
Lines 28398 28398
==========================================
+ Hits 22429 22724 +295
+ Misses 5969 5674 -295
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Lets see what happens! |
quantize
was catching exception silently, it now let the exception be catched by the caller to avoid dead path.Also, introduces extras dependencies ["onnxruntime"] required to quantize a model and installs the extra when running slow tests.