Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ONNX test_quantize unittest #6716

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Fix ONNX test_quantize unittest #6716

merged 3 commits into from
Aug 25, 2020

Conversation

mfuntowicz
Copy link
Member

quantize was catching exception silently, it now let the exception be catched by the caller to avoid dead path.

Also, introduces extras dependencies ["onnxruntime"] required to quantize a model and installs the extra when running slow tests.

Signed-off-by: Morgan Funtowicz <funtowiczmo@gmail.com>
Signed-off-by: Morgan Funtowicz <funtowiczmo@gmail.com>
Signed-off-by: Morgan Funtowicz <funtowiczmo@gmail.com>
@mfuntowicz mfuntowicz added the Tests Related to tests label Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #6716 into master will increase coverage by 1.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6716      +/-   ##
==========================================
+ Coverage   78.98%   80.01%   +1.03%     
==========================================
  Files         156      156              
  Lines       28398    28398              
==========================================
+ Hits        22429    22724     +295     
+ Misses       5969     5674     -295     
Impacted Files Coverage Δ
src/transformers/modeling_tf_albert.py 21.47% <0.00%> (-69.44%) ⬇️
src/transformers/modeling_tf_flaubert.py 24.53% <0.00%> (-63.81%) ⬇️
src/transformers/tokenization_dpr.py 53.15% <0.00%> (-4.51%) ⬇️
src/transformers/modeling_utils.py 88.05% <0.00%> (+0.55%) ⬆️
src/transformers/modeling_tf_utils.py 87.29% <0.00%> (+2.60%) ⬆️
src/transformers/generation_tf_utils.py 86.46% <0.00%> (+5.01%) ⬆️
src/transformers/configuration_t5.py 96.42% <0.00%> (+10.71%) ⬆️
src/transformers/modeling_t5.py 83.83% <0.00%> (+12.21%) ⬆️
src/transformers/modeling_tf_t5.py 90.93% <0.00%> (+64.09%) ⬆️
src/transformers/modeling_tf_electra.py 98.95% <0.00%> (+73.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc0202...b0d57be. Read the comment docs.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sshleifer
Copy link
Contributor

Lets see what happens!

@sshleifer sshleifer merged commit ac9702c into master Aug 25, 2020
@sshleifer sshleifer deleted the onnx-quantize-test-fix branch August 25, 2020 17:24
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants