Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF optimizer #6717

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Fix TF optimizer #6717

merged 1 commit into from
Aug 26, 2020

Conversation

jplu
Copy link
Contributor

@jplu jplu commented Aug 25, 2020

Fix #6560. Now the parameter experimental_aggregate_gradients should be correctly taken into account.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #6717 into master will decrease coverage by 0.33%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6717      +/-   ##
==========================================
- Coverage   79.77%   79.44%   -0.34%     
==========================================
  Files         156      156              
  Lines       28392    28392              
==========================================
- Hits        22650    22556      -94     
- Misses       5742     5836      +94     
Impacted Files Coverage Δ
src/transformers/optimization_tf.py 57.65% <50.00%> (ø)
src/transformers/modeling_tf_xlnet.py 21.12% <0.00%> (-71.05%) ⬇️
src/transformers/modeling_roberta.py 77.37% <0.00%> (-19.71%) ⬇️
src/transformers/modeling_tf_utils.py 86.64% <0.00%> (-0.66%) ⬇️
src/transformers/file_utils.py 82.41% <0.00%> (+0.25%) ⬆️
src/transformers/generation_tf_utils.py 86.46% <0.00%> (+1.25%) ⬆️
src/transformers/tokenization_xlnet.py 90.09% <0.00%> (+23.42%) ⬆️
src/transformers/tokenization_mbart.py 95.31% <0.00%> (+39.06%) ⬆️
src/transformers/modeling_tf_albert.py 90.90% <0.00%> (+69.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841f071...5281631. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and short, thanks!

@LysandreJik LysandreJik merged commit 02e8cd5 into huggingface:master Aug 26, 2020
@jplu jplu deleted the fix-tf-optimizer branch September 22, 2020 14:35
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Huggingface create_optimizer method not working
3 participants