-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TF optimizer #6717
Fix TF optimizer #6717
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6717 +/- ##
==========================================
- Coverage 79.77% 79.44% -0.34%
==========================================
Files 156 156
Lines 28392 28392
==========================================
- Hits 22650 22556 -94
- Misses 5742 5836 +94
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and short, thanks!
This reverts commit 859af85.
Fix #6560. Now the parameter
experimental_aggregate_gradients
should be correctly taken into account.