[seq2seq Examples] Use _step instead of generate for val, test #7004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patil-suraj
reviewed
Sep 8, 2020
| num_beams=self.eval_beams, | ||
| ) | ||
| loss_tensors, logits = self._step(batch) | ||
| if self.eval_beams == 0: |
There was a problem hiding this comment.
@patil-suraj : I updated that assertion above :).
Good point on creating an additional arg, though. I was veering on the side of fewer args, but this might also be something that's useful as an explicit arg than a hidden one. I don't have a strong opinion either way.
There was a problem hiding this comment.
aah right, I missed the updated assertion .
Right, not super important. Just a nit
|
@sshleifer : Does it make sense to still add this? If yes, I can rebase and update based on Suraj's comments earlier. If not, will close. |
|
Let's hold off for now. I think passing --eval_num_beams=1 is close enough to equivalent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a workaround I proposed in #6589 for limiting the memory consumption in
.generatesteps.@sshleifer