[tokenizers] Fixing #8001 - Adding tests on tokenizers serialization #8006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomwolf
changed the title
thomwolf
commented
Oct 23, 2020
| special_tokens (:obj:`list`, optional): | ||
| List of special tokens to be added to the end of the vocabulary. | ||
|
|
||
|
|
||
| """ | ||
|
|
||
| def __init__(self, vocab_file=None, do_lower_case=True, special_tokens=None): |
There was a problem hiding this comment.
Was not used in the class so I think it's better to remove it from the init args.
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…ialization (huggingface#8006) * fixing huggingface#8001 * make T5 tokenizer serialization more robust - style
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…zers serialization (huggingface#8006)" This reverts commit 9f79b9a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8001
Now the tokenizers classes have to send all the keyword arguments of the
__init__up to the base class of the tokenizer (bysuper().__init__) were they are stored ininit_kwargsfor serialized saving/reloading withsave_pretrained/from_pretrained.Adding a test on tokenizers serialization that all the keyword arguments of the
__init__are found in the savedinit_kwargsto avoid forgetting to send some arguments up in future (and current) tokenizers.Make T5 tokenizer serialization more robust.
Before submitting
Pull Request section?
to the it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.