Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an edge case of the blenderbot-90 tokenizer.
Closes #8029
Context
If the blenderbot-90 tokenizer is used to tokenize the following sequence:
It will split it in two tokens at first:
transformers/src/transformers/tokenization_blenderbot.py
Line 221 in 8bbe824
Those two tokens will be
['Ok', '.']
The issue is that, when passed the second token, the
bpe
method will convert it from'.'
to' .'
here:transformers/src/transformers/tokenization_blenderbot.py
Line 160 in 8bbe824
This then gets split on spaces here:
transformers/src/transformers/tokenization_blenderbot.py
Line 166 in 8bbe824
This is where the issue lies, as it creates two strings:
["", "."]
, the first one being empty.It then crashes a bit further as we try to index the empty string:
transformers/src/transformers/tokenization_blenderbot.py
Line 171 in 8bbe824
Proposal
Ensure that the token has a length > 0 before trying to manage it, otherwise ignore that token.
Added a test.