Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IterableDataset with __len__ in Trainer #8095

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

cccntu
Copy link
Contributor

@cccntu cccntu commented Oct 27, 2020

What does this PR do?

Fix #8087
Bring back support for IterableDataset with __len__ in Trainer. Changed in #7858

@sgugger

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I'm not really sure I understand why you're wrapping a Dataset in an IterableDataset as it seems there would be simpler ways to iterate over your data, this change LGTM!

@sgugger sgugger merged commit 286dc19 into huggingface:master Oct 27, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#7858 breaks IterableDataset with __len__ in Trainer
3 participants