-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PrefixConstrainedLogitsProcessor #8529
Merged
patrickvonplaten
merged 13 commits into
huggingface:master
from
nicola-decao:add_PrefixConstrainedLogitsProcessor
Nov 18, 2020
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6b3d5bb
Adding PrefixConstrainedLogitsProcessor
nicola-decao 05516af
fixing RAG and style_doc
nicola-decao fd6a815
fixing black (v20 instead of v19)
nicola-decao 41b3fad
Improving doc in generation_logits_process.py
nicola-decao e706e1d
Improving docs and typing in generation_utils.py
nicola-decao 45cfd93
docs improvement
nicola-decao 7d70ed9
final fixes in docs
nicola-decao 1443aff
adding test and fixing doc typo
nicola-decao bb3a228
fixing doc_len
nicola-decao 78cc520
isort on test
nicola-decao 9c98ceb
fixed test
nicola-decao e413dcc
Merge remote-tracking branch 'main/master' into add_PrefixConstrained…
patrickvonplaten ce32257
improve docstring a bit
patrickvonplaten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future PR we could probably speed this up by just using
torch.Tensor
operations and not Python loops. Python loops really slow down the computation on GPU apparently (see: #6064). But we can do this in a future PR as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to keep the same signature as in fairseq as if someone has already implemented one it can use the same.