-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] implement support for run-time dependency version checking #8645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition and I think will save us from a lot of repetitive version mismatch issues - thanks a lot @stas00 !
Two things:
- I don't think tokenizers is a mandatory dependency
- Not sure if need this functionality to write a dependency table file. Curious to hear your thoughts here though!
@sgugger, wrt your comment in your announcement
After this PR, you can just |
@LysandreJik and @sgugger - it's ready to merge whenever you have a chance to review. Thank you. Probably it is best to merge post v4-release, in case I missed something. |
Will do a final review tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Could you please pass the new parts of the setup.py though the formatter? There are some inconsistencies with the rest of the library (using single quotes instead of double quotes, dicts have weird spacing). Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thank you for your work on this Stas.
As discussed at #8073 (comment) this PR:
install_requires
(i.e. must modules)examples/lightning_base.py
to a fatal-on-failure requirement check.setup.py
'sextras
definitions andinstall_requires
Makefile
targetdeps_table_update
that updates the dep table, and inserts it intostyle/quality/fixup
targets so the sync shouldn't take too long if forgotten to be run explicitly@sgugger, @LysandreJik, @patrickvonplaten, @thomwolf