New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use return_dict in RagModel forward pass #8665

Closed

lhoestq wants to merge 1 commit into huggingface:master from lhoestq:fix-rag-model-return_dict

Member

lhoestq commented Nov 19, 2020

There were changes in the output format of models bu it looks like the RagModel forward pass was not updated to use return_dict as noticed in #8653

I'm running the slow tests right now. If they pass I will update from draft pull request to open request


          use return_dict in RagModel forward pass

7a815a9

lhoestq mentioned this pull request

Fix rag finetuning + add finetuning test #8585

Merged

Member Author

lhoestq commented Nov 20, 2020

Closing since it was fixed in #8585

lhoestq closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet