Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big model table #8774

Merged
merged 5 commits into from
Nov 25, 2020
Merged

Big model table #8774

merged 5 commits into from
Nov 25, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 25, 2020

What does this PR do?

This PR adds a big table in the first page of the doc, indicating whether each of our models has support for a slow/fast tokenizer, PyTorch, TensorFlow and Flax. Result can be found here (scroll a bit down).
It is updated automatically via make fix-copies and checked for updates in make quality, being built form the content of the auto models module.

There were a few issues with the imports on the flax side that I fixed in passing, and I renamed a constant to add the FLAX prefix. @mfuntowicz this doesn't really change anything but pinging you just so you're aware.

@sgugger sgugger requested a review from LysandreJik November 25, 2020 01:23
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in love

docs/source/index.rst Outdated Show resolved Hide resolved
sgugger and others added 2 commits November 25, 2020 09:10
Co-authored-by: Julien Chaumond <chaumond@gmail.com>
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @sgugger!

@LysandreJik LysandreJik merged commit 4821ea5 into master Nov 25, 2020
@LysandreJik LysandreJik deleted the big_model_table branch November 25, 2020 17:02
LysandreJik pushed a commit that referenced this pull request Nov 30, 2020
* First draft

* Styling

* With all changes staged

* Update docs/source/index.rst

Co-authored-by: Julien Chaumond <chaumond@gmail.com>

* Styling

Co-authored-by: Julien Chaumond <chaumond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants