Warning about too long input for fast tokenizers too #8799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
requested review from
thomwolf and
LysandreJik
and removed request for
thomwolf
|
Failing tests seem to come from some other code (seq2seq) |
LysandreJik
reviewed
Nov 27, 2020
Comment on lines
3165
to
3170
| """ | ||
| Clean up a list of simple English tokenization artifacts like spaces before punctuations and abbreviated forms. | ||
| clean up a list of simple english tokenization artifacts like spaces before punctuations and abbreviated forms. | ||
|
|
||
| Args: | ||
| out_string (:obj:`str`): The text to clean up. | ||
| args: out_string (:obj:`str`): the text to clean up. | ||
|
|
||
| Returns: | ||
| :obj:`str`: The cleaned-up string. | ||
| returns: :obj:`str`: the cleaned-up string. |
There was a problem hiding this comment.
The docstring was in the correct style before the changes
There was a problem hiding this comment.
But I simply ran the documentation fixer :(
|
@thomwolf could you review this PR as you're the mastermind behind this code? |
If truncation is not set in tokenizers, but the tokenization is too long for the model (`model_max_length`), we used to trigger a warning that The input would probably fail (which it most likely will). This PR re-enables the warning for fast tokenizers too and uses common code for the trigger to make sure it's consistent across.
Narsil
force-pushed
the
warning_for_too_long_input
branch
from
201db80 to
a4ecb3a
Compare
|
@LysandreJik May I merge (failing tests and quality is linked to unrelated |
LysandreJik
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If truncation is not set in tokenizers, but the tokenization is too long
for the model (
model_max_length), we used to trigger a warning thatThe input would probably fail (which it most likely will).
This PR re-enables the warning for fast tokenizers too and uses common code
for the trigger to make sure it's consistent across.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.
@LysandreJik
@thomwolf