Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] skip docs-only jobs take #2 #8853

Merged
merged 10 commits into from
Dec 1, 2020
Merged

[CI] skip docs-only jobs take #2 #8853

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3be6c4e
restore skip
stas00 Nov 30, 2020
dfec84d
Revert "Remove deprecated `evalutate_during_training` (#8852)"
stas00 Nov 30, 2020
4c37d05
check that pipeline.git.base_revision is defined before proceeding
stas00 Dec 1, 2020
c40d62a
Revert "Revert "Remove deprecated `evalutate_during_training` (#8852)""
stas00 Dec 1, 2020
7dc5da7
check that pipeline.git.base_revision is defined before proceeding
stas00 Dec 1, 2020
e1f8ec1
doc only
stas00 Dec 1, 2020
aa449b1
doc + code
stas00 Dec 1, 2020
9e216fb
restore
stas00 Dec 1, 2020
6ab950f
restore
stas00 Dec 1, 2020
b6ecec9
typo
stas00 Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,18 @@ commands:
- run:
name: docs-only changes skip check
command: |
if git diff --name-only << pipeline.git.base_revision >>...<< pipeline.git.revision >> | egrep -qv '\.(md|rst)$'
# pipeline.git.base_revision is not always defined, so only proceed if all external vars are defined
if test -n "<< pipeline.git.base_revision >>" && test -n "<< pipeline.git.revision >>"
then
echo "Non-docs were modified in this PR, proceeding normally"
if git diff --name-only << pipeline.git.base_revision >>...<< pipeline.git.revision >> | egrep -qv '\.(md|rst)$'
then
echo "Non-docs were modified in this PR, proceeding normally"
else
echo "Only docs were modified in this PR, quitting this job"
circleci step halt
fi
else
echo "Only docs were modified in this PR, quitting this job"
circleci step halt
echo "Can't perform skipping check w/o base_revision defined, continuing the job"
fi

# TPU REFERENCES
Expand Down Expand Up @@ -88,7 +94,7 @@ jobs:
parallelism: 1
steps:
- checkout
# - skip-job-on-doc-only-changes
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-torch_and_tf-{{ checksum "setup.py" }}
Expand All @@ -115,7 +121,7 @@ jobs:
parallelism: 1
steps:
- checkout
# - skip-job-on-doc-only-changes
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-torch-{{ checksum "setup.py" }}
Expand All @@ -142,7 +148,7 @@ jobs:
parallelism: 1
steps:
- checkout
# - skip-job-on-doc-only-changes
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-tf-{{ checksum "setup.py" }}
Expand All @@ -169,7 +175,7 @@ jobs:
parallelism: 1
steps:
- checkout
# - skip-job-on-doc-only-changes
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-flax-{{ checksum "setup.py" }}
Expand All @@ -196,7 +202,7 @@ jobs:
parallelism: 1
steps:
- checkout
# - skip-job-on-doc-only-changes
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-torch-{{ checksum "setup.py" }}
Expand All @@ -223,7 +229,7 @@ jobs:
parallelism: 1
steps:
- checkout
# - skip-job-on-doc-only-changes
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-tf-{{ checksum "setup.py" }}
Expand All @@ -248,7 +254,7 @@ jobs:
RUN_CUSTOM_TOKENIZERS: yes
steps:
- checkout
# - skip-job-on-doc-only-changes
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-custom_tokenizers-{{ checksum "setup.py" }}
Expand Down Expand Up @@ -276,7 +282,7 @@ jobs:
parallelism: 1
steps:
- checkout
# - skip-job-on-doc-only-changes
- skip-job-on-doc-only-changes
- restore_cache:
keys:
- v0.4-torch_examples-{{ checksum "setup.py" }}
Expand Down