Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TF OpenAi GPT1 Sequence Classification #9105

Merged
merged 4 commits into from
Dec 15, 2020
Merged

Added TF OpenAi GPT1 Sequence Classification #9105

merged 4 commits into from
Dec 15, 2020

Conversation

spatil6
Copy link
Contributor

@spatil6 spatil6 commented Dec 14, 2020

This PR implements Sequence classification for TF OpenAi GPT1 model.
TFOpenAIGPTForSequenceClassification uses the last token in order to do the classification, as other causal models (e.g. Transformer XL ,GPT-2) do.

Fixes #7623

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@LysandreJik @jplu

jplu
jplu approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@jplu jplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks for adding this!

LysandreJik
LysandreJik approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for working on this! LGTM!

src/transformers/models/openai/modeling_tf_openai.py Outdated Show resolved Hide resolved
@spatil6 @LysandreJik
Update src/transformers/models/openai/modeling_tf_openai.py
d3f365d 
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
@spatil6
Copy link
Contributor Author

spatil6 commented Dec 15, 2020 •
edited
Loading

Not sure, why test cases are failing for 'run_tests_tf'. @LysandreJik .
Let me know any action require from my side.

@jplu
Copy link
Contributor

jplu commented Dec 15, 2020

Can you rebase on master, a fix has been recently merged.

@LysandreJik
Copy link
Member

The tests have already been fixed on master, merging! Thanks a lot @spatil6

@LysandreJik LysandreJik merged commit 389aba3 into huggingface:master Dec 15, 2020
@spatil6 spatil6 deleted the tf_gpt1_seq_classifier branch December 19, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@jplu jplu jplu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PyTorch and/or TensorFlow sequence classification architectures for causal language models
3 participants
@spatil6 @jplu @LysandreJik