Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TF CTRL Sequence Classification #9151

Merged
merged 4 commits into from
Dec 17, 2020

Conversation

spatil6
Copy link
Contributor

@spatil6 spatil6 commented Dec 16, 2020

This PR implements Sequence classification for TF CTRL model.
TFCTRLForSequenceClassification uses the last token in order to do the classification, as other causal models (e.g. Transformer XL ,GPT-2) do.

Fixes #7623

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

@jplu @LysandreJik

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your contributions @spatil6, they are very welcome!

@LysandreJik LysandreJik requested a review from jplu December 16, 2020 21:57
Copy link
Contributor

@jplu jplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for your work!

@LysandreJik LysandreJik merged commit 467e915 into huggingface:master Dec 17, 2020
@spatil6 spatil6 deleted the tf_ctrl_seq_classification branch December 19, 2020 14:54
guyrosin pushed a commit to guyrosin/transformers that referenced this pull request Jan 15, 2021
* Added TF CTRL Sequence Classification

* code refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PyTorch and/or TensorFlow sequence classification architectures for causal language models
3 participants