Added TF TransfoXL Sequence Classification #9169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il6/transformers into tf_transfoxl_seq_classifier
LysandreJik
requested changes
Dec 18, 2020
There was a problem hiding this comment.
This LGTM. @jplu if you have nothing to say, feel free to merge the PR.
LysandreJik
approved these changes
Dec 18, 2020
spatil6
commented
Dec 19, 2020
tests/test_modeling_tf_transfo_xl.py
Outdated
| @@ -131,6 +141,12 @@ def create_and_check_transfo_xl_lm_head(self, config, input_ids_1, input_ids_2, | |||
| [(self.mem_len, self.batch_size, self.hidden_size)] * self.num_hidden_layers, | |||
| ) | |||
|
|
|||
| def create_and_check_transfo_xl_for_sequence_classification(self, config, input_ids_1, input_ids_2, lm_labels): | |||
| config.num_labels = self.num_labels | |||
There was a problem hiding this comment.
@LysandreJik I have defined 'num_labels' here.
Now,I'll move it to 'prepare_config_and_inputs'
Added num_labels to config level
Added num_labels to config level
…il6/transformers into tf_transfoxl_seq_classifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Sequence classification for TF TransfoXL model.
TFTransfoXLForSequenceClassification uses the last token in order to do the classification, as other causal models (e.g. GPT-1 ,GPT-2) do.
Fixes #7623
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
@LysandreJik @jplu