-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model Templates for Seq2Seq #9251
Merged
patrickvonplaten
merged 18 commits into
huggingface:master
from
patrickvonplaten:cookie_cutter_for_seq_2_seq
Dec 22, 2020
Merged
Model Templates for Seq2Seq #9251
patrickvonplaten
merged 18 commits into
huggingface:master
from
patrickvonplaten:cookie_cutter_for_seq_2_seq
Dec 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
sgugger
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding those!
...ecutter-template-{{cookiecutter.modelname}}/modeling_{{cookiecutter.lowercase_modelname}}.py
Outdated
Show resolved
Hide resolved
...ecutter-template-{{cookiecutter.modelname}}/modeling_{{cookiecutter.lowercase_modelname}}.py
Outdated
Show resolved
Hide resolved
...ecutter-template-{{cookiecutter.modelname}}/modeling_{{cookiecutter.lowercase_modelname}}.py
Outdated
Show resolved
Hide resolved
...el/cookiecutter-template-{{cookiecutter.modelname}}/{{cookiecutter.lowercase_modelname}}.rst
Show resolved
Hide resolved
Improvements to TFBart: #9252 are now included in this PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the possibility to generate Encoder-Decoder models via the cookie-cutter tool.
Model is correctly generated for PT and TF with all tests passing. Two test files are added.
These templates should very much facilitate the addition of Pegasus, Blenderbot, Marian as separate model files as well as adding BigBird, etc...
Please note that for now the safety checks:
# Copied from transformers.models.bart.modeling_bart...
are only added for very few layers because:decoder_input_ids
is a special feature and not the default case, Sinusoidal position embeddings are IMO also not general enough to be in the templatesmodeling_bart.py
still has theadd_layer_norm
hacks which are not copied to the model templates. When Bart is separated into Pegasus, etc... those if-else hacks can be deleted frommodeling_bart.py
at which point some more# Copied from transformers.models.bart.modeling_bart...
should be added to the Seq2Seq model templates