Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF T5 #9301

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Fix TF T5 #9301

merged 3 commits into from
Dec 28, 2020

Conversation

jplu
Copy link
Contributor

@jplu jplu commented Dec 24, 2020

What does this PR do?

This PR fix a couple of bug in T5, one for graph compliancy and another one for the past output.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM! Would you mind running the T5 slow integration tests to ensure that these changes don't break anything?

@jplu
Copy link
Contributor Author

jplu commented Dec 28, 2020

Already run of course 😉 and I can tell you that they all pass!

@patrickvonplaten patrickvonplaten merged commit d97d06d into huggingface:master Dec 28, 2020
@jplu jplu deleted the fix-tf-t5 branch December 29, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants