Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prophetnet] wrong import #9349

Merged
merged 1 commit into from
Dec 29, 2020
Merged

[prophetnet] wrong import #9349

merged 1 commit into from
Dec 29, 2020

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Dec 29, 2020 

python -c "from apex.normalization import FusedProphetNetLayerNorm"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: cannot import name 'FusedProphetNetLayerNorm' from 'apex.normalization' (/home/stas/anaconda3/envs/main-38/lib/python3.8/site-packages/apex/normalization/__init__.py)

It looks like this code has never been tested, so it silently fails inside try/except.

Discovered this by accident in #9338 (comment)

@patrickvonplaten, @LysandreJik

note, prophetnet is missing from .github/PULL_REQUEST_TEMPLATE.md, .github/ISSUE_TEMPLATE/bug-report.md

@stas00
[prophetnet] wrong import
cc7d56d 
```
python -c "from apex.normalization import FusedProphetNetLayerNorm"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: cannot import name 'FusedProphetNetLayerNorm' from 'apex.normalization' (/home/stas/anaconda3/envs/main-38/lib/python3.8/site-packages/apex/normalization/__init__.py)
```
It looks like this code has never been tested, so it silently fails inside try/except.

Discovered this by accident in #9338 (comment)
@stas00 stas00 mentioned this pull request Dec 29, 2020
Closed
patrickvonplaten
patrickvonplaten approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @stas00

@patrickvonplaten patrickvonplaten merged commit 8217d4e into master Dec 29, 2020
@patrickvonplaten patrickvonplaten deleted the stas00-patch-3 branch December 29, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stas00 @patrickvonplaten