[GenerationOutputs] Fix GenerationOutputs Tests #9443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
reviewed
Jan 6, 2021
patrickvonplaten
commented
Jan 6, 2021
| @@ -522,6 +522,7 @@ def test_greedy_generate_dict_outputs_use_cache(self): | |||
| return | |||
|
|
|||
| config.use_cache = True | |||
| config.is_decoder = True | |||
There was a problem hiding this comment.
make sure to use causal mask for models like BERT, RoBERTa, ...
patrickvonplaten
commented
Jan 6, 2021
| @@ -455,7 +455,7 @@ def prepare_inputs_for_generation( | |||
| "decoder_attention_mask": decoder_attention_mask, | |||
| "decoder_input_ids": decoder_inputs["input_ids"], | |||
| "encoder_outputs": encoder_outputs, | |||
| "past_key_values": past, | |||
| "past_key_values": decoder_inputs["past_key_values"], | |||
There was a problem hiding this comment.
@patil-suraj -> think this is a bit safer
patrickvonplaten
commented
Jan 6, 2021
| @@ -570,7 +570,7 @@ def prepare_inputs_for_generation(self, input_ids, past=None, attention_mask=Non | |||
| if past is not None: | |||
| input_ids = input_ids[:, -1:] | |||
|
|
|||
| return {"input_ids": input_ids, "attention_mask": attention_mask} | |||
| return {"input_ids": input_ids, "attention_mask": attention_mask, "past_key_values": past} | |||
There was a problem hiding this comment.
@patil-suraj we forgot to add this in the BERT cache PR. Bert-like models can also be used as stand-alone BertForCausalLM models -> so we need to return past_key_values here.
|
This PR actually made me correct 2 bugs additionally:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
GenerationOutputsPR: #9150 was not rebased, so that the cicrle ci on master is red now. This PR fixes it.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.