Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right version of tokenizers #9550

Merged
merged 7 commits into from
Jan 12, 2021
Merged

Use the right version of tokenizers #9550

merged 7 commits into from
Jan 12, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jan 12, 2021

What does this PR do?

Pulls the version of tokenziers from our deps in the hubconf.py otherwise it might install a version of tokenizers that is more recent (if available on pypi). When that is the case, the check of our packages fails at import.

@sgugger sgugger requested a review from LysandreJik January 12, 2021 23:14
@sgugger
Copy link
Collaborator Author

sgugger commented Jan 12, 2021

Test passes, so merging to get the CI green.

@sgugger sgugger merged commit 5f67210 into master Jan 12, 2021
@sgugger sgugger deleted the fix_torchhub1 branch January 12, 2021 23:55
guyrosin pushed a commit to guyrosin/transformers that referenced this pull request Jan 15, 2021
* Use the right version of tokenizers

* Try another way

* Try another way

* Deps are installed from there...

* Deps are installed from there...

* Revert last

* remove needless comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant