Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable multiple eval datasets #1052

Merged
merged 7 commits into from
Dec 6, 2023
Merged

enable multiple eval datasets #1052

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
38759eb
enable multiple eval datasets
peter-sk Dec 2, 2023
9b39833
Merge branch 'main' into feat/multiple-eval-datasets
peter-sk Dec 4, 2023
adced52
added test
peter-sk Dec 5, 2023
6dd5244
Merge branch 'feat/multiple-eval-datasets' of https://github.com/pete…
peter-sk Dec 5, 2023
29ae72f
try to avoid infinite computation
peter-sk Dec 6, 2023
5da74d8
make sure eval set is not infinite
peter-sk Dec 6, 2023
1b0a9da
downsizing the test
peter-sk Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions trl/trainer/sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,17 +241,22 @@ def make_inputs_require_grad(module, input, output):
chars_per_token,
)
if eval_dataset is not None:
eval_dataset = self._prepare_dataset(
eval_dataset,
tokenizer,
packing,
dataset_text_field,
max_seq_length,
formatting_func,
infinite,
num_of_sequences,
chars_per_token,
)
_multiple = isinstance(eval_dataset, dict)
_eval_datasets = eval_dataset if _multiple else {"singleton": eval_dataset}
for _eval_dataset_name, _eval_dataset in _eval_datasets.items():
_eval_datasets[_eval_dataset_name] = self._prepare_dataset(
_eval_dataset,
tokenizer,
packing,
dataset_text_field,
max_seq_length,
formatting_func,
infinite,
num_of_sequences,
chars_per_token,
)
if not _multiple:
eval_dataset = _eval_datasets["singleton"]

if tokenizer.padding_side is not None and tokenizer.padding_side != "right":
warnings.warn(
Expand Down
Loading