SFT Tokenizer Fix #1142
Merged
SFT Tokenizer Fix #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ChrisCates
force-pushed
the
@chriscates/sft-tokenizer-fix
branch
from
fed4e1b to
af52453
Compare
|
@younesbelkada, updated the commit with the |
younesbelkada
approved these changes
Dec 27, 2023
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After experiencing issues with GPTQ Conversion, discussed in this issue #1138.
I was able to resolve it by passing the Tokenizer into the
SFTTrainer.I also noticed that lowering
gradient_accumulation_stepshelps resolve thelinalg.choleskyerror experienced with pytorch.I've left a note under
Best Practicesin thesft_trainer.mdxfile.We can decide where to best put this note in regards to GPTQ Conversion.