Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add peft_module_casting_to_bf16 in DPOTrainer #1143

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

sywangyi
Copy link
Contributor

No description provided.

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

@younesbelkada

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@younesbelkada
Copy link
Contributor

@sywangyi can you run the styling checks? make precommit

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

trl/trainer/dpo_trainer.py Outdated Show resolved Hide resolved
@younesbelkada younesbelkada merged commit 95ec857 into huggingface:main Dec 26, 2023
9 checks passed
@younesbelkada
Copy link
Contributor

Thanks @kashif @sywangyi !

lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
* add peft_module_casting_to_bf16 in DPOTrainer

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>

* Update trl/trainer/dpo_trainer.py

---------

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants