Logs metrics on all distributed processes when using DPO & FSDP #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log metrics on all distributed processes
|
cc @kashif |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Does this affect classic DPO on multi-GPU + distributed without FSDP? If not, I think we can safely merge it, would you be able to quickly try that out @AjayP13 ? 🙏
|
@younesbelkada Yes, I tested this distributed with FSDP enabled and distributed with FSDP disabled (DDP, I believe) and both seemed to work fine. |
|
yes all good! |
kashif
approved these changes
Jan 15, 2024
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
Log metrics on all distributed processes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs metrics on all distributed processes when using FSDP.
All processes need access to the metrics in order for things like "Early Stopping" / "Load Best Model At End" to work. You get a
KeyErroron workers #1 - #N, otherwise.There is no need for this guard as the logging callbacks themselves check if they are the main process before printing metrics to the terminal.