Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch all gather #1177

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

vwxyzjn
Copy link
Contributor

@vwxyzjn vwxyzjn commented Jan 4, 2024

Closes #1103

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lvwerra lvwerra merged commit ec3d41b into huggingface:main Jan 4, 2024
9 checks passed
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
* Fix batch all gather

* quick fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PPO script hangs when logging to wandb in multi-gpu environments
3 participants