Check tokenize params on DPOTrainer #1197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we tokenize the dataset on the
DPOTrainer.__init__
regardless of having a customdata_collator
, we need to ensure that atokenizer
is passed and warm about the need to setmax_length
,max_prompt_length
andmax_target_length
. Hence, moving those checks outside of thedata_collator
check.On older implementations these parameters were only needed if the user did not provide a
data_collator
but they are now required for all DPO runs.@kashif