Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Address issue #1122" #1205

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Revert "Address issue #1122" #1205

merged 1 commit into from
Jan 9, 2024

Conversation

younesbelkada
Copy link
Contributor

Reverts #1174

@younesbelkada younesbelkada requested a review from lvwerra January 9, 2024 09:18
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada merged commit d171551 into main Jan 9, 2024
9 checks passed
@younesbelkada younesbelkada deleted the revert-1174-issue-1122 branch January 9, 2024 09:20
@maneandrea
Copy link
Contributor

Was this issue ever investigated / solved? I could work on it but can you provide more info on what wasn't working in the snippets? Thanks!

@younesbelkada
Copy link
Contributor Author

Hi @maneandrea yes that would be great if you can help on this 🙏 Thanks !

lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants