Refactor RewardConfig to own module #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Jan 12, 2024
| # coding=utf-8 | ||
| # coding=utf-8 | ||
| # Copyright 2023 The HuggingFace Team. All rights reserved. | ||
| # Copyright 2024 The HuggingFace Team. All rights reserved. |
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* Refactor RewardConfig to own module * Fix init * Fix import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion here: #1181 (comment)
Basic idea is to have have a dedicated config per trainer, each in their own module. Since the code path was never exposed as an absolute path, I believe this is backwards compatible