Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model Generation config to reflect new special tokens #1256

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

philschmid
Copy link
Member

@philschmid philschmid commented Jan 19, 2024

What does this PR do?

This PR updates the generation config, which is used by default when using model.generate. Therefore we should update the token ids to make sure user has the expected behavior.

cc @younesbelkada

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@younesbelkada younesbelkada merged commit a3c5b71 into huggingface:main Jan 22, 2024
9 checks passed
@philschmid philschmid deleted the patch-1 branch January 22, 2024 14:34
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants