Fix doc snippet PPOTrainer argument train_dataset -> dataset #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the argument's name as well as the value need to be renamed. Otherwise we get both NameError: name 'train_dataset' is not defined and TypeError: PPOTrainer.__init__() got an unexpected keyword argument 'train_dataset'
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Feb 6, 2024
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
Both the argument's name as well as the value need to be renamed. Otherwise we get both NameError: name 'train_dataset' is not defined and TypeError: PPOTrainer.__init__() got an unexpected keyword argument 'train_dataset'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the argument's name and the value need to be renamed in the code snippet. Otherwise we get both
NameError: name 'train_dataset' is not definedand
TypeError: PPOTrainer.__init__() got an unexpected keyword argument 'train_dataset'