fix serialization of RunningMoments on multiple GPUs #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashif
approved these changes
Aug 1, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
thanks @claralp could you kindly run the pre-commit to fix the formatting? |
claralp
force-pushed
the
bco_checkpointing_fix
branch
from
03a713f to
a1e7613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is related to PR #1869
When training in a distributed setup, the collected count of the RunningMoments class ended up being a tensor, not an integer. This led to errors in json serializtion.
This fixes the type of xs_count in distributed trainings.
Previous fix (see c220350) caused tests to fail and was therefore reverted by @kashif. Also @seanexp