Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orpo trainer loss device #1919

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Fix orpo trainer loss device #1919

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
298edb0
fix orpo trainer loss device
SunMarc Aug 12, 2024
bccd7bc
Merge remote-tracking branch 'origin/main' into fix-orpo-trainer-loss…
SunMarc Aug 12, 2024
a99b9cd
Merge branch 'main' into fix-orpo-trainer-loss-device
SunMarc Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions trl/trainer/orpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,9 @@ def compute_loss(
with compute_loss_context_manager:
loss, metrics = self.get_batch_loss_metrics(model, inputs, train_eval="train")

# Make sure to move the loss to the device the original accumulating loss is at back in the `Trainer` class:
loss = loss.to(self.args.device)

# force log the metrics
self.store_metrics(metrics, train_eval="train")

Expand Down
Loading