Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prompts arg from WinrateCallback #2010

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Sep 3, 2024

What does this PR do?

Fixes #1859

Remove "prompt" (not used). Instead, the prompts come from the eval dataset.

  def __init__(
       self,
-      prompts: List[str],
       judge: BaseRankJudge,
       trainer: Trainer,
       generation_config: Optional[GenerationConfig] = None,
       batch_size: int = 4,
  ):

I also add some tests and doc.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec linked an issue Sep 3, 2024 that may be closed by this pull request
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec merged commit 1f6a1d2 into main Sep 3, 2024
10 checks passed
@qgallouedec qgallouedec deleted the 1859-prompts-are-not-used-in-winratecallback branch September 3, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prompts are not used in WinRateCallback
3 participants