Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #2181

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Update CONTRIBUTING.md #2181

merged 2 commits into from
Oct 7, 2024

Conversation

kushal34712
Copy link
Contributor

fixed typo and corrected grammer

@qgallouedec
Copy link
Member

I let native English speakers review this one 😉

@kushal34712
Copy link
Contributor Author

@qgallouedec why not sir, just check it once and merge it if possible

@kushal34712
Copy link
Contributor Author

@qgallouedec sir it its reviewed then merge it please

@qgallouedec
Copy link
Member

Hi @kushal34712 as I've written, I've requested the review of native english speakers. It will be merged when reviewed

CONTRIBUTING.md Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif added the 📚 documentation Improvements or additions to documentation label Oct 6, 2024
Copy link
Collaborator

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kushal34712 for your patience. We aim to review PRs in detail (even doc changes) so please allow us the time to do this.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@lewtun lewtun merged commit ac038ef into huggingface:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants