Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop decoder_input_ids in DPOTrainer #2208

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

qgallouedec
Copy link
Member

What does this PR do?

Since we only use the logits (and not the returned loss), it seems like decoder_input_ids is useless as an input for encoder-decoder models.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec
Copy link
Member Author

qgallouedec commented Oct 9, 2024

The new curves are significantly smoother compared to before.

Screenshot 2024-10-09 at 17 52 10

I believe this is due to padding completions without applying a loss mask, causing the loss to be calculated over the entire sequence, including the padding tokens:

batch["chosen_labels"] = [
seq + [tokenizer.pad_token_id] * (max_length - len(seq)) for seq in batch["chosen_labels"]
]
batch["rejected_labels"] = [
seq + [tokenizer.pad_token_id] * (max_length - len(seq)) for seq in batch["rejected_labels"]
]

@qgallouedec qgallouedec marked this pull request as ready for review October 9, 2024 15:57
@kashif kashif added 🐛 bug Something isn't working 🏋 DPO Related to DPO labels Oct 10, 2024
@qgallouedec qgallouedec merged commit 4197916 into main Oct 10, 2024
10 checks passed
@qgallouedec qgallouedec deleted the drop-decoder_input_ids branch October 10, 2024 08:20
qgallouedec added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🏋 DPO Related to DPO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants